Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add DfdaemonUpload.sync_host. #929

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

baowj-678
Copy link
Contributor

@baowj-678 baowj-678 commented Jan 6, 2025

Description

  • Implement DfdaemonUpload.sync_host to respond for SyncHost requests.

Related Issue

dragonflyoss/dragonfly#3713

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)
    Checklist
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@baowj-678 baowj-678 requested a review from a team as a code owner January 6, 2025 02:18
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 77 lines in your changes missing coverage. Please review.

Project coverage is 43.63%. Comparing base (83bbf19) to head (9dd0ab4).

Files with missing lines Patch % Lines
dragonfly-client/src/grpc/dfdaemon_upload.rs 0.00% 77 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #929      +/-   ##
==========================================
- Coverage   43.93%   43.63%   -0.30%     
==========================================
  Files          58       58              
  Lines       11103    11179      +76     
==========================================
  Hits         4878     4878              
- Misses       6225     6301      +76     
Files with missing lines Coverage Δ
dragonfly-client/src/grpc/dfdaemon_upload.rs 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add parent selector to resource.

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove tokio::spawn.

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many problems. Continue to optimize the code.

@baowj-678 baowj-678 changed the title feat: add HostInfo and DfdaemonUpload.sync_host. feat: add DfdaemonUpload.sync_host. Jan 23, 2025
@gaius-qi gaius-qi mentioned this pull request Jan 24, 2025
8 tasks
@baowj-678 baowj-678 requested a review from gaius-qi February 25, 2025 04:33
@gaius-qi gaius-qi force-pushed the main branch 3 times, most recently from f952c04 to 033e67a Compare March 4, 2025 15:36
gaius-qi
gaius-qi previously approved these changes Mar 11, 2025
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants