Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show cluster name and id in updating cluster #263

Merged
merged 2 commits into from
Aug 18, 2023
Merged

fix: show cluster name and id in updating cluster #263

merged 2 commits into from
Aug 18, 2023

Conversation

Liam-Zhao
Copy link
Collaborator

@Liam-Zhao Liam-Zhao commented Aug 18, 2023 •
edited
Loading

Description

Related Issue

Fixes #257

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@Liam-Zhao Liam-Zhao added the bug Something isn't working label Aug 18, 2023
@Liam-Zhao Liam-Zhao self-assigned this Aug 18, 2023
@Liam-Zhao Liam-Zhao requested a review from a team as a code owner August 18, 2023 09:35
@Liam-Zhao Liam-Zhao force-pushed the fix--Show-cluster-name-and-id-in-updating-cluster branch from ff7ed31 to 39b2229 Compare August 18, 2023 09:35
gaius-qi
gaius-qi approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 16829e1 into main Aug 18, 2023
5 checks passed
@gaius-qi gaius-qi deleted the fix--Show-cluster-name-and-id-in-updating-cluster branch August 18, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaius-qi gaius-qi gaius-qi approved these changes

@liubin liubin Awaiting requested review from liubin liubin is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@anjia0532 anjia0532 Awaiting requested review from anjia0532 anjia0532 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

@cndoit18 cndoit18 Awaiting requested review from cndoit18 cndoit18 is a code owner automatically assigned from dragonflyoss/dragonfly2-reviewers

Assignees

@Liam-Zhao Liam-Zhao

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show cluster name and id in updating cluster
2 participants
@Liam-Zhao @gaius-qi