Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change page loading function #367

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Conversation

Liam-Zhao
Copy link
Collaborator

@Liam-Zhao Liam-Zhao commented Apr 17, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@Liam-Zhao Liam-Zhao added the enhancement New feature or request label Apr 17, 2024
@Liam-Zhao Liam-Zhao requested a review from gaius-qi April 17, 2024 09:01
@Liam-Zhao Liam-Zhao self-assigned this Apr 17, 2024
@Liam-Zhao Liam-Zhao requested a review from a team as a code owner April 17, 2024 09:01
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.50%. Comparing base (fe701dd) to head (4aeb0e8).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   98.46%   98.50%   +0.03%     
==========================================
  Files          27       28       +1     
  Lines        2939     3017      +78     
  Branches      870      885      +15     
==========================================
+ Hits         2894     2972      +78     
  Misses         44       44              
  Partials        1        1              
Files Coverage Δ
src/components/clusters/edit.tsx 99.53% <100.00%> (+0.03%) ⬆️
src/components/clusters/index.tsx 100.00% <100.00%> (ø)
src/components/clusters/show.tsx 99.34% <100.00%> (+0.01%) ⬆️
src/components/developer/tokens/edit.tsx 99.04% <100.00%> (+0.14%) ⬆️
src/components/developer/tokens/index.tsx 97.22% <100.00%> (+0.07%) ⬆️
src/components/insight/peers/index.tsx 96.38% <100.00%> (+0.05%) ⬆️
src/components/job/preheats/index.tsx 99.19% <100.00%> (+0.03%) ⬆️
src/components/job/preheats/new.tsx 99.42% <100.00%> (+0.02%) ⬆️
src/components/job/preheats/show.tsx 99.04% <100.00%> (+0.03%) ⬆️
src/components/loading-backdrop.tsx 100.00% <100.00%> (ø)
... and 5 more

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit d7c47f1 into main Apr 17, 2024
8 checks passed
@gaius-qi gaius-qi deleted the feat--change-page-loading-function branch April 17, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants