Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: preheat agrs adds parameter piece length #368

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

Liam-Zhao
Copy link
Collaborator

@Liam-Zhao Liam-Zhao commented Apr 18, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@Liam-Zhao Liam-Zhao added the enhancement New feature or request label Apr 18, 2024
@Liam-Zhao Liam-Zhao requested a review from gaius-qi April 18, 2024 06:11
@Liam-Zhao Liam-Zhao self-assigned this Apr 18, 2024
@Liam-Zhao Liam-Zhao requested a review from a team as a code owner April 18, 2024 06:11
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.48%. Comparing base (d7c47f1) to head (b147c0b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   98.50%   98.48%   -0.03%     
==========================================
  Files          28       28              
  Lines        3017     3034      +17     
  Branches      887      883       -4     
==========================================
+ Hits         2972     2988      +16     
- Misses         44       45       +1     
  Partials        1        1              
Files Coverage Δ
src/components/job/preheats/new.tsx 99.45% <100.00%> (+0.03%) ⬆️
src/lib/api.ts 93.47% <ø> (ø)
src/components/job/preheats/show.tsx 98.18% <80.00%> (-0.87%) ⬇️

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit ad998ef into main Apr 18, 2024
8 checks passed
@gaius-qi gaius-qi deleted the feat--preheat-agrs-adds-parameter-piece-length branch April 18, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants