Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add changes to scheduler features #391

Merged
merged 10 commits into from
Sep 12, 2024

Conversation

Liam-Zhao
Copy link
Collaborator

@Liam-Zhao Liam-Zhao commented Sep 11, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@Liam-Zhao Liam-Zhao self-assigned this Sep 11, 2024
@Liam-Zhao Liam-Zhao requested a review from a team as a code owner September 11, 2024 13:18
@Liam-Zhao Liam-Zhao added the enhancement New feature or request label Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.14%. Comparing base (10300ba) to head (7fc36c4).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
- Coverage   98.26%   98.14%   -0.13%     
==========================================
  Files          30       31       +1     
  Lines        3173     3287     +114     
  Branches      954      988      +34     
==========================================
+ Hits         3118     3226     +108     
- Misses         52       59       +7     
+ Partials        3        2       -1     
Files with missing lines Coverage Δ
src/components/clusters/edit.tsx 99.52% <ø> (ø)
src/components/clusters/index.tsx 100.00% <100.00%> (ø)
src/components/clusters/information.tsx 100.00% <100.00%> (ø)
src/components/clusters/new.tsx 100.00% <ø> (ø)
src/components/clusters/show.tsx 97.03% <100.00%> (-1.26%) ⬇️
src/components/developer/tokens/edit.tsx 99.00% <ø> (ø)
src/components/developer/tokens/index.tsx 97.34% <100.00%> (+0.07%) ⬆️
src/components/developer/tokens/new.tsx 98.76% <ø> (ø)
src/components/insight/peers/index.tsx 96.33% <100.00%> (ø)
src/components/job/preheats/index.tsx 98.95% <ø> (ø)
... and 8 more

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 402e683 into main Sep 12, 2024
8 checks passed
@gaius-qi gaius-qi deleted the feat--add-changes-to-scheduler-features branch September 12, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants