Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: number of active schedulers misspell #398

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

Liam-Zhao
Copy link
Collaborator

@Liam-Zhao Liam-Zhao commented Sep 25, 2024

Description

Related Issue

Fixed dragonflyoss/Dragonfly2#3538.

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@Liam-Zhao Liam-Zhao added the bug Something isn't working label Sep 25, 2024
@Liam-Zhao Liam-Zhao self-assigned this Sep 25, 2024
@Liam-Zhao Liam-Zhao requested a review from a team as a code owner September 25, 2024 13:55
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.17%. Comparing base (b8e77ff) to head (306d1a2).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #398   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files          31       31           
  Lines        3286     3286           
  Branches      987      988    +1     
=======================================
  Hits         3226     3226           
  Misses         58       58           
  Partials        2        2           
Files with missing lines Coverage Δ
src/components/clusters/show.tsx 97.03% <ø> (ø)

@gaius-qi gaius-qi merged commit e868d5c into main Sep 25, 2024
8 checks passed
@gaius-qi gaius-qi deleted the fix--number-op-active-schedulers-misspell branch September 25, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in dashboard
2 participants