Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change menu style #408

Merged
merged 3 commits into from
Nov 8, 2024
Merged

feat: change menu style #408

merged 3 commits into from
Nov 8, 2024

Conversation

Liam-Zhao
Copy link
Collaborator

@Liam-Zhao Liam-Zhao commented Nov 7, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: zhaoxinxin <[email protected]>
@Liam-Zhao Liam-Zhao added the enhancement New feature or request label Nov 7, 2024
@Liam-Zhao Liam-Zhao self-assigned this Nov 7, 2024
@Liam-Zhao Liam-Zhao requested a review from a team as a code owner November 7, 2024 09:41
Signed-off-by: zhaoxinxin <[email protected]>
Signed-off-by: zhaoxinxin <[email protected]>
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.22%. Comparing base (741b3a0) to head (3c22f12).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #408   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files          36       36           
  Lines        3831     3836    +5     
  Branches     1164     1200   +36     
=======================================
+ Hits         3763     3768    +5     
  Misses         64       64           
  Partials        4        4           
Files with missing lines Coverage Δ
src/components/menu/index.tsx 96.51% <100.00%> (+0.21%) ⬆️

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 137a233 into main Nov 8, 2024
8 checks passed
@gaius-qi gaius-qi deleted the feat--change-menu branch November 8, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants