Skip to content

storage: use global thread pool to support prefetch#1187

Closed
jiangliu wants to merge 1 commit intodragonflyoss:masterfrom
jiangliu:prefetch
Closed

storage: use global thread pool to support prefetch#1187
jiangliu wants to merge 1 commit intodragonflyoss:masterfrom
jiangliu:prefetch

Conversation

@jiangliu
Copy link
Copy Markdown
Contributor

Currently we use a prefetch manager per backend, this design has two drawbacks:

  • spawn too many worker threads for prefetch
  • the network ratelimit has been defunct

So change the design to use a global prefetch manager with thread pool to supporrt all prefetch requests.

@jiangliu jiangliu requested a review from a team as a code owner March 31, 2023 02:40
@jiangliu jiangliu requested review from bergwolf, imeoer and liubogithub and removed request for a team March 31, 2023 02:40
@anolis-bot
Copy link
Copy Markdown
Collaborator

@jiangliu , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/63200

@anolis-bot
Copy link
Copy Markdown
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd❌ FAIL

Sorry, your test job failed. Please get the details in the link.

Currently we use a prefetch manager per backend, this design has two
drawbacks:
- spawn too many worker threads for prefetch
- the network ratelimit has been defunct

So change the design to use a global prefetch manager with thread pool
to supporrt all prefetch requests.

Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
@anolis-bot
Copy link
Copy Markdown
Collaborator

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/63211

@anolis-bot
Copy link
Copy Markdown
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@jiangliu jiangliu requested a review from changweige March 31, 2023 06:47
Copy link
Copy Markdown
Contributor

@ccx1024cc ccx1024cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test for improvement is required.

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open 60 days with no activity.

@github-actions github-actions Bot added the Stale label Aug 18, 2025
@github-actions
Copy link
Copy Markdown

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions Bot closed this Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants