Closed
Conversation
liubogithub
requested review from
gaius-qi,
imeoer and
jiangliu
and removed request for
a team
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1654 +/- ##
==========================================
- Coverage 60.05% 60.04% -0.01%
==========================================
Files 147 147
Lines 49624 49624
Branches 47078 47078
==========================================
- Hits 29802 29799 -3
- Misses 18040 18042 +2
- Partials 1782 1783 +1
🚀 New features to boost your workflow:
|
Collaborator
|
Not really sure, it seems the changes break some CI tests due to IO errors: https://github.com/dragonflyoss/nydus/actions/runs/12311443544/job/34446727113?pr=1654 |
Contributor
Author
|
Thanks, let me figure it out. |
Based on the error definition, InvalidData is preferable than InvalidInput. Data not valid for the operation were encountered. Unlike [InvalidInput], this typically means that the operation parameters were valid, however the error was caused by malformed input data. For example, a function that reads a file into a string will error with InvalidData if the file's contents are not valid UTF-8. Signed-off-by: Liu Bo <liub.liubo@gmail.com>
With error macros, debug mode can show more informations such as stack trace. Signed-off-by: Liu Bo <liub.liubo@gmail.com>
|
This PR is stale because it has been open 60 days with no activity. |
|
This PR is stale because it has been open 60 days with no activity. |
|
This PR is stale because it has been open 60 days with no activity. |
|
This PR was closed because it has been stalled for 7 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the error definition, InvalidData is preferable than InvalidInput.
Data not valid for the operation were encountered. Unlike [InvalidInput], this typically means that the operation parameters were valid, however the error was caused by malformed input data. For example, a function that reads a file into a string will error with InvalidData if the file's contents are not valid UTF-8.
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.