Skip to content

Conversation

@Arohi-jd
Copy link

@Arohi-jd Arohi-jd commented Dec 4, 2025

This pull request addresses Issue #754 by performing a set of non-functional cleanup tasks aimed at improving code readability, maintainability, and consistency across the codebase.
No behavioral or feature changes were introduced.

Summary of Changes

  1. Removed unnecessary debug logging

Cleaned up leftover debugging statements to reduce noise in production code:

Workspace.jsx – replaced console.log(error) with console.error(error)

db.js – removed console.log(e)

ControlPanel.jsx – removed console.log(error)

CodeEditor/index.jsx – removed console.log(e)

Modal.jsx – removed console.log(error)

This ensures proper error logging while maintaining cleaner output.

  1. Removed outdated TODO comments

Deleted TODOs that were either irrelevant or already obsolete:

TypeInfo.jsx – removed legacy TODO related to index cleanup

dbml.js – removed outdated TODO while keeping the required timestamptz mapping logic intact

  1. Cleaned up unused props

Since data.id is always available, some props and references were unnecessary:

TypeInfo.jsx

Removed unused index prop

Updated internal references to use data.id consistently

Updated itemKey to use data.id

TypesTab.jsx

Removed passing of the index prop to

Verification

Diagrams load and render correctly

Types tab functions as expected

DBML export behavior remains unchanged

Error logging is now more consistent and intentional

Conclusion

This cleanup improves overall clarity and maintainability without altering existing functionality.
The application continues to operate as expected after these changes.

@vercel
Copy link

vercel bot commented Dec 4, 2025

@Arohi-jd is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Arohi-jd
Copy link
Author

Arohi-jd commented Dec 4, 2025

Hi @1ilit , this PR is ready for review.
Build checks have passed — only Vercel failed due to fork permissions.
Kindly review whenever you get time. Thank you!

@1ilit
Copy link
Member

1ilit commented Dec 5, 2025

dont need this rn

@1ilit 1ilit closed this Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants