fix: clear timers when controller disposed (#4528)

Co-authored-by: Wubo Cao <[email protected]>

e2e/disposing/disposing.spec.ts

@@ -47,7 +47,7 @@ test('no error on constructing and disposing sheet unit', async ({ page }) => {
         errored = true;
     });
 
-    await page.goto('http://localhost:3000/sheets/', { waitUntil: 'networkidle' });
+    await page.goto('http://localhost:3000/sheets/');
     await page.evaluate(() => window.E2EControllerAPI.disposeCurrSheetUnit());
     await page.evaluate(() => window.E2EControllerAPI.loadDefaultSheet());
 

e2e/perf/scroll.spec.ts

@@ -16,7 +16,7 @@
 
 import type { Page } from '@playwright/test';
 /* eslint-disable no-console */
-import { chromium, expect, test } from '@playwright/test';
+import { expect, test } from '@playwright/test';
 import { sheetData as emptySheetData } from '../__testing__/emptysheet';
 import { sheetData as freezeData } from '../__testing__/freezesheet';
 import { sheetData as mergeCellData } from '../__testing__/mergecell';
@@ -135,14 +135,15 @@ async function measureFPS(page: Page, testDuration = 5, deltaX: number, deltaY:
 const createTest = (title: string, sheetData: IJsonObject, minFpsValue: number, deltaX = 0, deltaY = 0) => {
     // Default Size Of browser: 1280x720 pixels. And default DPR is 1.
     test(title, async ({ page }) => {
-        let port = 3000;
-        if (!isCI) {
-            const browser = await chromium.launch({ headless: false }); // launch browser
-            page = await browser.newPage();
-            port = 3002;
-        }
-
-        await page.goto(`http://localhost:${port}/sheets/`);
+        // dev:e2e open localhost:3000, not 3002
+        // let port = 3000;
+        // if (!isCI) {
+        //     const browser = await chromium.launch({ headless: false }); // launch browser
+        //     page = await browser.newPage();
+        //     port = 3002;
+        // }
+
+        await page.goto('http://localhost:3000/sheets/');
         await page.waitForTimeout(2000);
 
         const windowOfPage = await page.evaluateHandle('window');

packages/sheets-formula/src/controllers/trigger-calculation.controller.ts

@@ -162,6 +162,8 @@ export class TriggerCalculationController extends Disposable {
 
         this._progress$.next(NilProgress);
         this._progress$.complete();
+        // clear timer when disposed
+        clearTimeout(this._setTimeoutKey);
     }
 
     private _commandExecutedListener() {

packages/sheets-ui/src/controllers/editor/editing.render-controller.ts

@@ -16,7 +16,7 @@
 
 /* eslint-disable max-lines-per-function */
 
-import type { DocumentDataModel, ICellData, ICommandInfo, IDisposable, IDocumentBody, IDocumentData, IDocumentStyle, IStyleData, Nullable, Styles, UnitModel, Workbook } from '@univerjs/core';
+import type { DocumentDataModel, ICellData, ICommandInfo, IDisposable, IDocumentBody, IDocumentData, IDocumentStyle, IStyleData, Nullable, Styles, Workbook } from '@univerjs/core';
 import type { IRichTextEditingMutationParams } from '@univerjs/docs';
 import type { IRenderContext, IRenderModule } from '@univerjs/engine-render';
 import type { WorkbookSelectionModel } from '@univerjs/sheets';
@@ -158,9 +158,10 @@ export class EditingRenderController extends Disposable implements IRenderModule
         this._commandExecutedListener(d);
         this._initSkeletonListener(d);
 
-        this.disposeWithMe(this._univerInstanceService.unitDisposed$.subscribe((_unit: UnitModel) => {
+        // RenderManagerService._disposeItem will calls EditingRenderController.dispose before unitDisposed$.subscribe,so that the timer won't be cleared
+        d.add(() => {
             clearTimeout(this._cursorTimeout);
-        }));
+        });
 
         // FIXME: this problem is the same with slide. Should be fixed when refactoring editor.
         this._cursorTimeout = setTimeout(() => {