Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix some permission bugs #4478

Merged
merged 4 commits into from
Jan 24, 2025
Merged

fix: fix some permission bugs #4478

merged 4 commits into from
Jan 24, 2025

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Jan 14, 2025

close #4457
close #4442

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jan 14, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jan 14, 2025
Copy link

github-actions bot commented Jan 14, 2025

Playwright test results

passed  23 passed

Details

stats  23 tests across 10 suites
duration  5 minutes, 9 seconds
commit  7c2045a
info  For more information, see full report

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 32.65%. Comparing base (1780109) to head (7c2045a).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
...ges/sheets-ui/src/views/formula-bar/FormulaBar.tsx 0.00% 25 Missing ⚠️
packages/sheets/src/facade/f-permission.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4478      +/-   ##
==========================================
+ Coverage   32.63%   32.65%   +0.01%     
==========================================
  Files        2598     2598              
  Lines      134870   134879       +9     
  Branches    30013    30020       +7     
==========================================
+ Hits        44021    44042      +21     
+ Misses      90849    90837      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ybzky ybzky force-pushed the fix-permission-bugs-0114 branch from c95e541 to 11bab47 Compare January 17, 2025 12:52
@ybzky ybzky force-pushed the fix-permission-bugs-0114 branch from f558190 to 7c2045a Compare January 23, 2025 10:00
@ybzky ybzky removed the qa:untested This PR is ready to be tested label Jan 24, 2025
@ybzky ybzky merged commit 2683655 into dev Jan 24, 2025
12 checks passed
@ybzky ybzky deleted the fix-permission-bugs-0114 branch January 24, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants