Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): add deprecate API #4539

Merged
merged 5 commits into from
Jan 23, 2025
Merged

chore(core): add deprecate API #4539

merged 5 commits into from
Jan 23, 2025

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 21, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jan 21, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Jan 21, 2025

Playwright test results

passed  23 passed

Details

stats  23 tests across 10 suites
duration  5 minutes, 9 seconds
commit  e52b352
info  For more information, see full report

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 32.66%. Comparing base (920b6d3) to head (e52b352).
Report is 20 commits behind head on dev.

Files with missing lines Patch % Lines
packages/core/src/services/log/log.service.ts 8.33% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4539      +/-   ##
==========================================
+ Coverage   32.61%   32.66%   +0.04%     
==========================================
  Files        2597     2598       +1     
  Lines      134822   134922     +100     
  Branches    30000    30025      +25     
==========================================
+ Hits        43976    44068      +92     
- Misses      90846    90854       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev marked this pull request as draft January 22, 2025 12:08
@wzhudev wzhudev marked this pull request as ready for review January 22, 2025 12:36
CONTRIBUTING.md Outdated Show resolved Hide resolved
@wzhudev wzhudev merged commit a104643 into dev Jan 23, 2025
12 checks passed
@wzhudev wzhudev deleted the feat/deprecation-warning branch January 23, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants