Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add ui facade menu position #4546

Merged
merged 3 commits into from
Jan 22, 2025
Merged

feat(ui): add ui facade menu position #4546

merged 3 commits into from
Jan 22, 2025

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 22, 2025

Change appendTo API, so users can specify where the menu will be appended to.

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jan 22, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Jan 22, 2025

Playwright test results

passed  23 passed

Details

stats  23 tests across 10 suites
duration  5 minutes, 9 seconds
commit  32977e5
info  For more information, see full report

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 32.64%. Comparing base (30c5e05) to head (32977e5).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
packages/ui/src/facade/f-menu-builder.ts 0.00% 15 Missing ⚠️
...ts-ui/src/views/sheet-container/SheetContainer.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4546      +/-   ##
==========================================
+ Coverage   32.63%   32.64%   +0.01%     
==========================================
  Files        2598     2598              
  Lines      134844   134859      +15     
  Branches    30006    30011       +5     
==========================================
+ Hits        44009    44030      +21     
+ Misses      90835    90829       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jikkai jikkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jikkai jikkai merged commit 9685cb3 into dev Jan 22, 2025
12 checks passed
@jikkai jikkai deleted the feat/ui-facade-path branch January 22, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants