Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): t formula bug fix #4556

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix(formula): t formula bug fix #4556

merged 1 commit into from
Jan 23, 2025

Conversation

wpxp123456
Copy link
Contributor

close #4464

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jan 23, 2025
Copy link

github-actions bot commented Jan 23, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@wpxp123456 wpxp123456 removed the qa:untested This PR is ready to be tested label Jan 23, 2025
Copy link

Playwright test results

passed  23 passed

Details

stats  23 tests across 10 suites
duration  5 minutes, 9 seconds
commit  958cc4a
info  For more information, see full report

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.65%. Comparing base (99127d7) to head (958cc4a).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4556   +/-   ##
=======================================
  Coverage   32.64%   32.65%           
=======================================
  Files        2598     2598           
  Lines      134859   134864    +5     
  Branches    30011    30012    +1     
=======================================
+ Hits        44030    44035    +5     
  Misses      90829    90829           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 5b7cc47 into dev Jan 23, 2025
12 checks passed
@wzhudev wzhudev deleted the pxp/01231128 branch January 23, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] VLOOKUP FORMULA Search for Matching items and Sum Calculation Error, Inconsistent with WPS Results
2 participants