Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): fix insert function of range has number value #4561

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

wpxp123456
Copy link
Contributor

@wpxp123456 wpxp123456 commented Jan 23, 2025

close #4161

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Jan 23, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Jan 23, 2025

Playwright test results

passed  23 passed

Details

stats  23 tests across 10 suites
duration  5 minutes, 8 seconds
commit  2a367c4
info  For more information, see full report

@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Jan 23, 2025
@wpxp123456 wpxp123456 removed the qa:untested This PR is ready to be tested label Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 62.96296% with 20 lines in your changes missing coverage. Please review.

Project coverage is 32.66%. Comparing base (1780109) to head (2a367c4).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...c/commands/operations/insert-function.operation.ts 69.38% 15 Missing ⚠️
...a/src/commands/commands/insert-function.command.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4561      +/-   ##
==========================================
+ Coverage   32.63%   32.66%   +0.02%     
==========================================
  Files        2598     2598              
  Lines      134870   134910      +40     
  Branches    30013    30023      +10     
==========================================
+ Hits        44021    44067      +46     
+ Misses      90849    90843       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wpxp123456 wpxp123456 merged commit 22f7159 into dev Jan 23, 2025
13 checks passed
@wpxp123456 wpxp123456 deleted the pxp/01231934 branch January 23, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants