Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(numfmt): reset cell value type when remove numfmt #4585

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Gggpound
Copy link
Contributor

@Gggpound Gggpound commented Feb 5, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Feb 5, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Feb 5, 2025

Playwright test results

failed  2 failed
passed  22 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 27 seconds
commit  961b1b6
info  For more information, see full report

Failed tests

chromium › memory/memory.spec.ts › memory
chromium › visual-comparison/sheets/sheets-visual-comparison.spec.ts › diff demo sheet content

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 32.71%. Comparing base (ff4ae42) to head (4dd3e44).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
.../src/controllers/numfmt-cell-content.controller.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4585      +/-   ##
==========================================
+ Coverage   32.63%   32.71%   +0.07%     
==========================================
  Files        2599     2600       +1     
  Lines      135065   135272     +207     
  Branches    30061    30134      +73     
==========================================
+ Hits        44080    44255     +175     
- Misses      90985    91017      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gggpound Gggpound force-pushed the fix-numfmt-0206 branch 2 times, most recently from ed39ffd to 8f05d69 Compare February 7, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant