Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: float dom after freeze #4587

Merged
merged 8 commits into from
Feb 7, 2025
Merged

fix: float dom after freeze #4587

merged 8 commits into from
Feb 7, 2025

Conversation

lumixraku
Copy link
Contributor

@lumixraku lumixraku commented Feb 7, 2025

close https://github.com/dream-num/univer-pro/issues/3967
clsoe https://github.com/dream-num/univer-pro/issues/3934

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Feb 7, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Feb 7, 2025

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 26 seconds
commit  4acf22b
info  For more information, see full report

@lumixraku lumixraku force-pushed the fix/float-dom-after-freeze branch from 0505eaa to ad925c0 Compare February 7, 2025 04:07
@univer-bot univer-bot bot added the qa:untested This PR is ready to be tested label Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 4.76190% with 80 lines in your changes missing coverage. Please review.

Project coverage is 32.69%. Comparing base (303c0b2) to head (4acf22b).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...i/src/services/canvas-float-dom-manager.service.ts 0.00% 61 Missing ⚠️
...der/src/components/sheets/sheet.render-skeleton.ts 0.00% 12 Missing ⚠️
...ers/render-controllers/freeze.render-controller.ts 0.00% 5 Missing ⚠️
packages/engine-render/src/viewport.ts 0.00% 1 Missing ⚠️
...ollers/format-painter/format-painter.controller.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4587      +/-   ##
==========================================
- Coverage   32.72%   32.69%   -0.04%     
==========================================
  Files        2600     2600              
  Lines      135245   135305      +60     
  Branches    30128    30138      +10     
==========================================
- Hits        44258    44237      -21     
- Misses      90987    91068      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added the qa:verified This PR has already by verified by a QA and is considered good enough to be merge label Feb 7, 2025
@univer-bot univer-bot bot removed the qa:untested This PR is ready to be tested label Feb 7, 2025
@lumixraku lumixraku force-pushed the fix/float-dom-after-freeze branch 2 times, most recently from 36345ac to d62307c Compare February 7, 2025 09:01
@lumixraku lumixraku force-pushed the fix/float-dom-after-freeze branch from d62307c to 4acf22b Compare February 7, 2025 09:18
@lumixraku lumixraku requested a review from weird94 February 7, 2025 09:36
@lumixraku lumixraku merged commit 9b2274f into dev Feb 7, 2025
12 checks passed
@lumixraku lumixraku deleted the fix/float-dom-after-freeze branch February 7, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants