Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): get dirtyRanges when row column removed #4588

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

Dushusir
Copy link
Member

@Dushusir Dushusir commented Feb 7, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Feb 7, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Feb 7, 2025

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 31 seconds
commit  88e1f07
info  For more information, see full report

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 32.72%. Comparing base (9732f7b) to head (88e1f07).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...formula/src/controllers/active-dirty.controller.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4588      +/-   ##
==========================================
+ Coverage   32.70%   32.72%   +0.02%     
==========================================
  Files        2600     2600              
  Lines      135271   135243      -28     
  Branches    30134    30127       -7     
==========================================
+ Hits        44234    44255      +21     
+ Misses      91037    90988      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VicKun4937
Copy link
Contributor

I have tested in pro, it works well.

@Dushusir Dushusir merged commit 0e0d68b into dev Feb 7, 2025
12 checks passed
@Dushusir Dushusir deleted the dushusir/formula-bugs-0207 branch February 7, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants