Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix multi memory leak problems #4591

Merged
merged 6 commits into from
Feb 7, 2025
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Feb 7, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Feb 7, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Feb 7, 2025

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 27 seconds
commit  17ee8e3
info  For more information, see full report

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 39.74359% with 47 lines in your changes missing coverage. Please review.

Project coverage is 32.71%. Comparing base (9b2274f) to head (17ee8e3).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
.../sheets-ui/src/controllers/auto-fill.controller.ts 39.13% 14 Missing ⚠️
...i/src/services/canvas-float-dom-manager.service.ts 0.00% 13 Missing ⚠️
...er-controllers/format-painter.render-controller.ts 0.00% 12 Missing ⚠️
...es/sheets/src/model/range-protection-rule.model.ts 63.63% 4 Missing ⚠️
...ing-ui/src/controllers/image-cropper.controller.ts 0.00% 3 Missing ⚠️
...s/permission/sheet-permission-render.controller.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4591   +/-   ##
=======================================
  Coverage   32.70%   32.71%           
=======================================
  Files        2600     2600           
  Lines      135305   135306    +1     
  Branches    30138    30141    +3     
=======================================
+ Hits        44258    44271   +13     
+ Misses      91047    91035   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev requested a review from weird94 as a code owner February 7, 2025 10:18
@wzhudev wzhudev force-pushed the fix/fix-memory-leak-interceptor branch from bf7772e to 9cbc3fe Compare February 7, 2025 10:20
@wzhudev wzhudev changed the title fix: fix render unit and interceptor memory leak fix: fix multi memory leak problems Feb 7, 2025
@wzhudev wzhudev merged commit 3dc94a9 into dev Feb 7, 2025
12 checks passed
@wzhudev wzhudev deleted the fix/fix-memory-leak-interceptor branch February 7, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants