Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core)!: move facade exports to facade directory and update imports #4596

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

hexf00
Copy link
Member

@hexf00 hexf00 commented Feb 7, 2025

close #xxx

BREAKING CHANGE:

The following imports previously from @univerjs/core should now be imported from @univerjs/core/facade:
FBase, FBaseInitialable, FUniver, FHooks, FBlob, IFBlobSource, FEventName, IEventBase, IEventParamConfig, FEnum, FUtil.

Before:

import { FUniver } from '@univerjs/core';

After:

import { FUniver } from '@univerjs/core/facade';

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@hexf00 hexf00 changed the title refactor: move facade exports to facade directory and update imports refactor!: move facade exports to facade directory and update imports Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

github-actions bot commented Feb 7, 2025

Playwright test results

passed  24 passed

Details

stats  24 tests across 11 suites
duration  5 minutes, 32 seconds
commit  1d9be58
info  For more information, see full report

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 32.68%. Comparing base (1f961b8) to head (1d9be58).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/core/src/facade/f-univer.ts 0.00% 7 Missing ⚠️
packages/core/src/facade/f-event-registry.ts 0.00% 5 Missing ⚠️
packages/core/src/facade/f-util.ts 0.00% 4 Missing ⚠️
packages/core/src/facade/f-blob.ts 0.00% 3 Missing ⚠️
packages/core/src/facade/f-base.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4596   +/-   ##
=======================================
  Coverage   32.68%   32.68%           
=======================================
  Files        2603     2603           
  Lines      135461   135461           
  Branches    30118    30118           
=======================================
  Hits        44277    44277           
  Misses      91184    91184           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hexf00 hexf00 changed the title refactor!: move facade exports to facade directory and update imports refactor(core)!: move facade exports to facade directory and update imports Feb 8, 2025
@hexf00 hexf00 force-pushed the feat/decouple-core-facade branch 2 times, most recently from afb44f5 to ec3abde Compare February 13, 2025 10:23
@hexf00 hexf00 force-pushed the feat/decouple-core-facade branch from ec3abde to 787ecbc Compare February 13, 2025 10:24
@hexf00 hexf00 marked this pull request as ready for review February 13, 2025 10:24
@hexf00 hexf00 merged commit a97741d into dev Feb 13, 2025
9 checks passed
@hexf00 hexf00 deleted the feat/decouple-core-facade branch February 13, 2025 15:21
@wzhudev wzhudev mentioned this pull request Feb 27, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant