Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: doc support horizontal line #4813

Merged
merged 2 commits into from
Mar 14, 2025
Merged

feat: doc support horizontal line #4813

merged 2 commits into from
Mar 14, 2025

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Mar 11, 2025

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Mar 11, 2025

View Deployment

📑 Demo (React@19) Demo (React@16) 📚 Storybook
🔗 Preview link 🔗 Preview link 🔗 Preview link

@Jocs Jocs force-pushed the feat/horizontal-line branch from 17f1a5f to e626cca Compare March 11, 2025 13:33
Copy link

github-actions bot commented Mar 11, 2025

Playwright test results

failed  1 failed
passed  24 passed

Details

stats  25 tests across 12 suites
duration  6 minutes, 7 seconds
commit  8b0eaeb
info  For more information, see full report

Failed tests

chromium › visual-comparison/docs/docs-visual-comparison.spec.ts › diff default doc content

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 3.44828% with 84 lines in your changes missing coverage. Please review.

Project coverage is 34.22%. Comparing base (3760ee8) to head (83aa1bc).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
...ocs-ui/src/commands/commands/doc-delete.command.ts 2.63% 37 Missing ⚠️
...ages/engine-render/src/components/docs/document.ts 0.00% 21 Missing ⚠️
...ocs-ui/src/commands/commands/break-line.command.ts 10.00% 9 Missing ⚠️
.../engine-render/src/components/docs/layout/tools.ts 0.00% 8 Missing ⚠️
...c/commands/commands/doc-horizontal-line.command.ts 25.00% 3 Missing ⚠️
...-render/src/components/docs/layout/doc-skeleton.ts 0.00% 3 Missing ⚠️
packages/docs-ui/src/controllers/menu/menu.ts 0.00% 2 Missing ⚠️
...ne-render/src/components/docs/layout/model/page.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4813      +/-   ##
==========================================
- Coverage   34.22%   34.22%   -0.01%     
==========================================
  Files        2610     2611       +1     
  Lines      136451   136533      +82     
  Branches    30325    30347      +22     
==========================================
+ Hits        46702    46722      +20     
- Misses      89749    89811      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jocs Jocs force-pushed the feat/horizontal-line branch 3 times, most recently from a6fbb3f to b07713f Compare March 12, 2025 13:25
@Jocs Jocs marked this pull request as ready for review March 13, 2025 03:18
@Jocs Jocs force-pushed the feat/horizontal-line branch from b07713f to 8b0eaeb Compare March 13, 2025 03:18
@Jocs Jocs merged commit cde1824 into dev Mar 14, 2025
9 checks passed
@Jocs Jocs deleted the feat/horizontal-line branch March 14, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants