Fix: typos #99
Fix: typos #99
Conversation
kouosi
commented
Oct 4, 2024
kouosi
commented
- Fix some spelling mistakes
- Remove some trailing space
| @@ -73,7 +73,7 @@ That took a little more work than grub, but this can (and should) be automated a | |||
| ### Limine.cfg | |||
| Similar to grub, limine also uses a config file. This config file has its own documentation, which is available in the limine repository. | |||
|
|
|||
| Limine.cfg lists each boot entry as a title, followed by a series of key-value pairs. To boot our example from above using stivale 2, our config might look like the following: | |||
| limine.cfg lists each boot entry as a title, followed by a series of key-value pairs. To boot our example from above using stivale 2, our config might look like the following: | |||
There was a problem hiding this comment.
it looks odd to start a sentence with lower case, maybe change to "The limine.cfg file lists each ..."
There was a problem hiding this comment.
If limine.cfg is in backticks, does grub.cfg also need to be?
There was a problem hiding this comment.
Yeah, let's keep things consistent.
| @@ -1,4 +1,4 @@ | |||
| # Boot Protocols | |||
| [#](#.md) Boot Protocols | |||
There was a problem hiding this comment.
I still see this odd syntax, [#](#.md), does it have any particular purpose? Otherwise i think it can be removed.
There was a problem hiding this comment.
Sorry my editor auto adds it for some reason
There was a problem hiding this comment.
lgtm.
Do you want to add yourself (or being added) to the contributors list? Here https://github.com/dreamportdev/Osdev-Notes/blob/master/99_Appendices/I_Acknowledgments.md ?
|
I’ll decline this request as I only fixed a typo and don’t consider it a contribution |
|
Thanks! Thanks again for your help. |
