Pr taxon menu#13
Closed
synrg wants to merge 81 commits into
Closed
Conversation
… now." This reverts commit cb90605.
- i.e. obs/spp by, ids by, unobserved by, etc. are actually counted, not taxa
- also support taxon counts by arbitrary user
- no str support needed - test now expects header
- move outside class, as no access to self needed - eliminate nested `with…client`
- core taxon command now shows the count of observations qualified by additional query arguments, if applicable, matching the behaviour of the bot taxon command
- qualified taxon counts are only of verifiable obs unless for a single user
- when creating a counts formatter from a query, omit the unused client parameter - hardwire counts source pagination to be 15 names per page for now as we don't yet parameterize it (probably belongs in the menu constructor)
- feature request for this in pyinat: pyinat/pyinaturalist#640
- `.countable` property now may also be for `.id_by` or `.unobserved_by`, not just `.user` or `.place` - new properties: - `.countable_name` is the name of the attribute to count - `.countable_value` is the value to count
Contributor
Author
|
Enough of the work has been merged back into devel branch to support inatcog that this PR can now be closed. Unfinished ideas in the checklist should have their own issues. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In support of dronefly-garden/dronefly#210
A non-exhaustive list of steps to get this PR in shape for use in the bot code, as it is currently far from complete:
addcommand to work with taxon menus that have place counts, not just user countsid by, etc.) in taxon & add commands.ctx(e.g. current page# & formatter), leaving only the currently active menu attached toctxinstead