Rework query#14
Open
synrg wants to merge 12 commits into
Open
Conversation
Contributor
Author
|
Note: when testing this PR with dronefly-cli, you must currently use dronefly-garden/dronefly-cli#9 |
- We also now separately asyncify annotations.all() under a new method annotations.async_all() in prepare_query as replacing it with the asyncified version breaks client.observations.search() which doesn't expect annotations.all() to be a coroutine.
- decouple config init from toml only needed for cli - put config attributes at top instead of nesting in data eliminating any need for 3 convenience methods to fetch all table entries - make config accessors async for easier subclassing with more complex behaviours in the bot code - carry the config on the Context object to simplify use in contextualized commands - add user lookaside when matching a user to allow abbrevs in config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework query as per #1
This will be messy for a while, first just pulling bits of the bot code into core, then tidying it up as we go.