Address Issue #258: Configuration predicate to control dependency graph creation #259
Conversation
|
|
|
|
…ncy graph creation Adds a new configuration option to allow the consumer to provision of a `Predicate<Configuration>` instance to customize what `Configuration` instances should be considered when building the dependency graph. # Conflicts: # affectedmoduledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleConfiguration.kt # affectedmoduledetector/src/main/kotlin/com/dropbox/affectedmoduledetector/DependencyTracker.kt # affectedmoduledetector/src/test/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleConfigurationTest.kt # affectedmoduledetector/src/test/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleDetectorImplTest.kt
|
@joshafeinberg - This PR has been sitting around for over a year now. I just rebased it to the latest HEAD. Any chance I could have you folks take a look at this? Thanks in advance. |
Sorry for the delay, we don't review PRs until the CLA is signed usually which I see you completed a couple days ago. Running against CI and can get this merged if all looks good |
|
Yeah, I had signed it initially but IIRC I got failures when attempting to submit the CLA. It seems to still be in a bit of a weird state with 2 comments, only one of which indicates that it had been signed. 🤷♂️ |
Fixes #258.
Adds a new configuration option to allow the consumer to provision of a
Predicate<Configuration>instance to customize whatConfigurationinstances should be considered when building the dependency graph.For your consideration, adding something like this would be very helpful for us. Appreciate the work y'all have done thus far.