Generate missing app auth routes, clean up task reconnection helpers #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
julianlocke
force-pushed
the
fix-app-auth-client-routes
branch
from
c38bcf1 to
c0224f1
Compare
jaquish
approved these changes
Jan 16, 2024
| @@ -13,11 +13,17 @@ public class DropboxAppBase: DropboxTransportClientOwning { | |||
| public var auth: AuthAppAuthRoutes! | |||
| /// Routes within the check namespace. See CheckAppAuthRoutes for details. | |||
| public var check: CheckAppAuthRoutes! | |||
| /// Routes within the files namespace. See FilesAppAuthRoutes for details. | |||
| public var files: FilesAppAuthRoutes! | |||
There was a problem hiding this comment.
Update diff title to note additional routes
| @@ -24,9 +24,85 @@ protocol PersistedRequestInfoBaseInfo { | |||
| var clientProvidedInfo: String? { get set } | |||
| } | |||
|
|
|||
| extension ReconnectionHelpers { | |||
| private static let Separator = "#?///?#" | |||
| private let Separator = "#?///?#" | |||
There was a problem hiding this comment.
Should this be in the default extension of ReconnectionHelpersShared instead of global space?
There was a problem hiding this comment.
I wish I could but you can't put a stored property there
There was a problem hiding this comment.
I made a small Constants struct to get it out of the global space
julianlocke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generates code from a new version of stone that remedies missing app auth routes from app auth clients when those routes have additional auth types.
App auth routes also now get their own reconnection helpers, and objc wrappers over reconnection helpers are slightly modified to avoid potentially creating unreachable defaults in switch statements.
See dropbox/stone#317 for stone changes and explanations.