Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macos-latest to release ios artifacts in GitHub Actions #16

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

takahirom
Copy link
Contributor

Hello dropbox/differ team,

I noticed that iOS artifacts are not being released due to the use of ubuntu-latest in GitHub Actions. To address this, I propose switching to macos-latest for builds targeting iOS, which should enable the automated release of iOS-compatible binaries.

I've implemented this change in the pull request. Integrating it would significantly benefit iOS developers using Kotlin Multiplatform.

Thank you for considering this update.

https://central.sonatype.com/search?q=com.dropbox.differ

@CLAassistant
Copy link

CLAassistant commented Apr 15, 2024

CLA assistant check
All committers have signed the CLA.

@rharter rharter merged commit 39d9317 into dropbox:main Apr 16, 2024
3 checks passed
@takahirom
Copy link
Contributor Author

@rharter
Thanks for merging this.
I found something related to this issue. If we use a Mac, we can release the iOS artifact, but we can't release the Linux artifact. We might need to use separate tasks and operating systems, similar to the KMP library template. Here's the reference: https://github.com/Kotlin/multiplatform-library-template/blob/main/.github/workflows/deploy.yml.

Although publishing on separate operating systems is ideal, I think this PR is better than just using Linux because iOS is a major use case for KMP.

By the way, Roborazzi is using differ, and we want to use the iOS artifact. If you're okay with the above comment, could you provide a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants