Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect pin of requests #505

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Fix incorrect pin of requests #505

merged 2 commits into from
Jun 3, 2024

Conversation

maxbelanger
Copy link
Contributor

@maxbelanger maxbelanger commented Jun 3, 2024

The change in #492 aimed to restore Python 2.7 support in CI. This included an attempt to avoid automatically pulling in urllib3>=2 as that introduces potential breaking changes. The change both (incorrectly) introduced a maximum version requirement for requests and (correctly) added a requirement to pin urllib3<2 (as suggested in the docs for requests and urllib3). It should only have done the latter.

This reverts the version requirement for requests to what it was prior to #492. Fixes #504.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.28%. Comparing base (1d379b4) to head (758ad80).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #505      +/-   ##
==========================================
+ Coverage   64.26%   64.28%   +0.02%     
==========================================
  Files          31       31              
  Lines       53579    53579              
  Branches     3905     3905              
==========================================
+ Hits        34430    34444      +14     
+ Misses      18989    18972      -17     
- Partials      160      163       +3     
Flag Coverage Δ
integration 64.19% <ø> (+0.02%) ⬆️
unit 63.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxbelanger maxbelanger marked this pull request as ready for review June 3, 2024 08:12
@maxbelanger maxbelanger requested review from greg-db and sderickson June 3, 2024 08:12
@maxbelanger maxbelanger merged commit b474e21 into main Jun 3, 2024
24 checks passed
@maxbelanger maxbelanger deleted the dbx-max-requirements branch June 3, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requests is pinned to <2.30, but requests prior to 2.32 is subject to CVE-2024-35195
2 participants