rustfmt everything except generated code #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I personally disagree with several of rustfmt's decisions, but it's better to be consistent. Generated code isn't being formatted because 1) it would have to get reformatted every time it gets generated; I'm not going to make the generator emit it so it matches rustfmt 2) rustfmt currently chokes on some of the generated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I personally disagree with several of rustfmt's decisions, but it's better to be consistent.
Generated code isn't being formatted because
not going to make the generator emit it so it matches rustfmt
Checklist
General Contributing
RELEASE_NOTES.mdfile, or believe it's not necessary for this change.Validation
existing automated tests