Enhance #83: Hook functionality #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POST to /api/hooks/ works to create new hooks
PUT to /api/hooks/[id]/ works to update existing hooks
DELETE to /api/hooks/[id]/ works to delete existing hooks
User will be inferred from the current authenticated one which
means either in X-NSoT-Email header or Auth_Token.
If trying to POST an existing token, an error similar to the normal
one is returned (HTTP 400 {status: error, error: { message: Hook must be unique, code: 400 } } )
|
* Linking this to #83 * |
| ModelClass = self.Meta.model | ||
| validated_data['user'] = self.context['request'].user | ||
| try: | ||
| obj = ModelClass.objects.create(**validated_data) |
There was a problem hiding this comment.
I would prefer that we still call the parent's .create() (e.g.obj = super(HookCreateUpdateSerializer, self).create(validated_data)) here, because it's doing more than just calling the model's .create() method. Everything else is great!
|
This is stale and using a not-really-maintained fork of django-rest-hooks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit log
Notes
This is ready to merge, but is lacking unittests therefore don't merge until we have some for it. Still this is progress!