Feature/shiny stone - #16
Open
EJCrispy wants to merge 9 commits into
Open
Conversation
… not sure if I need to do something special for the asset to line up, and because It's my first time doing this I probably fucked up. Also the code might be shit but we will see. Anyways I'm supposed to describe my change so: Added new debuff that prevents shiny stone from working, preventing players from switching shiny stone on/off whenever they need to heal.
… not sure if I need to do something special for the asset to line up, and because It's my first time doing this I probably fucked up. Also the code might be shit but we will see. Anyways I'm supposed to describe my change so: Added new debuff that prevents shiny stone from working, preventing players from switching shiny stone on/off whenever they need to heal. Also this time im pushing this to remote.
Author
|
Shoulda changed the title |
drunderscore
requested changes
Apr 7, 2025
drunderscore
left a comment
drunderscore
left a comment
Owner
There was a problem hiding this comment.
Awesome. I know understand why this item is a little silly in PvP 🙄
Most comments could be removed if the code sufficiently explains what it does or if it isn't appropriate... although I am known to be bad at that -- I'll go through and remove my poor comments.
Try formatting your code inside of your editor before you commit. If it doesn't do anything that's alright, I'll go make an editor config and deal with it later.
Comment on lines
+17
to
+49
| public class ShinyStoneDisabler : ModPlayer | ||
| { | ||
| private bool hadShinyStoneLastFrame; | ||
|
|
||
| public override void PostUpdateEquips() | ||
| { | ||
| // Check if Shiny Stone is equipped | ||
| bool hasShinyStone = IsShinyStoneEquipped(); | ||
|
|
||
| // Apply debuff when first equipped or when you relog and rejoin (unintentional but works so who gafs) | ||
| if (hasShinyStone && !hadShinyStoneLastFrame) | ||
| { | ||
| Player.AddBuff(ModContent.BuffType<ShinyStoneHotswap>(), 3600); // 60 seconds of charging upon being swapped on | ||
| } | ||
|
|
||
| // Disable Shiny Stone effects while debuffed (it just works) | ||
| if (Player.HasBuff(ModContent.BuffType<ShinyStoneHotswap>())) | ||
| { | ||
| Player.shinyStone = false; | ||
| } | ||
|
|
||
| hadShinyStoneLastFrame = hasShinyStone; | ||
| } | ||
|
|
||
| public override void OnRespawn() | ||
| { | ||
| // We re-apply debuff if equipped and you respawn | ||
| //TODO: we could maybe make it so that if you equip the shiny stone witin the bounds of the spawnbox you don't get the Charging debuff | ||
| if (IsShinyStoneEquipped()) | ||
| { | ||
| Player.AddBuff(ModContent.BuffType<ShinyStoneHotswap>(), 900); // 15 seconds of Charging after respawning | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
I made the decision long ago that TML is too stupid to get their internal names correctly (in a proper and pleasing way) for us to bother having multiple ModPlayer for multiple features, as much as I would want this.
Let's collapse this into AdventurePlayer
Collaborator
There was a problem hiding this comment.
dont worry guys i fixed it
| //TODO: we could maybe make it so that if you equip the shiny stone witin the bounds of the spawnbox you don't get the Charging debuff | ||
| if (IsShinyStoneEquipped()) | ||
| { | ||
| Player.AddBuff(ModContent.BuffType<ShinyStoneHotswap>(), 900); // 15 seconds of Charging after respawning |
Owner
There was a problem hiding this comment.
This should be squashed into the preceding commit.
…is works but I don't have high hopes not going to lie.
…is works but I don't have high hopes not going to lie. Added the shiny stone code I wrote from addon to here. Truthfully I'm not sure if I need to do something special for the asset to line up, and because It's my first time doing this I probably fucked up. Also the code might be shit but we will see. Anyways I'm supposed to describe my change so: Added new debuff that prevents shiny stone from working, preventing players from switching shiny stone on/off whenever they need to heal. Also this time im pushing this to remote.
…Adventure into feature/shiny-stone
…sition. Still can't see errors
Owner
|
If you want a review on this from me, you'll have to squash and force-push to the branch so I can figure out what's going on -- like this I'll never be able to review it. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically added a new debuff that I call "Charged" but it won't be called that because I didn't change the localization. But basically this debuff will prevent the shinystone item from doing, and you get this debuff for 60 seconds whenever shinystone is switched on, and 15 seconds when you respawn with shinystone equipped. Also I don't know if the asset will sync with it, I don't really know if that works but we will see I suppose.