This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
Allow ./... as a build target
#8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcarlisle
force-pushed
the
ive-never-normalized-a-thing-in-my-life
branch
from
33d8e8f to
0ae9e6a
Compare
This breaks the common target `./...` which behaves differently from `...`
pcarlisle
force-pushed
the
ive-never-normalized-a-thing-in-my-life
branch
from
0ae9e6a to
65d65cc
Compare
pcarlisle
changed the title
./... as a build target
|
This rewrote index.js a lot more than I expected, possibly I did something weird? |
|
feel free to leave comments here but i'm going to open a new pr with the sameish contents against actions/go-dependency-submission |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go interprets
./...as distinct from...when finding build targets. Avoid normalizing this path in order to keep the/. Go treats the targets./...andalldifferently. When using./...test targets will be ignored, whereasallincludes them.