-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow configuring clear-cache statically and injecting torn writes at runtime #7
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
bfc23e9
api: inject torn-op and torn-seq via FIFO
mj-ramos 1686eff
api: added crash and clear as configured faults
mj-ramos 599e178
fix: fix parsing torn-op
mj-ramos f37333e
fix: revert persist_write
mj-ramos 0297343
fix: crash via config
mj-ramos 6830ffb
readme: fault update
mj-ramos 6ed20c0
readme: fix text
mj-ramos 150ab12
readme: update api
mj-ramos 219976b
libpcache: rename functions and remove runtime errors when faults are…
mj-ramos b382002
faults.hpp: fix documentation
mj-ramos be9ac8a
faults: update name of fault clear to clear-cache
mj-ramos af2c7b8
lazyfs: fix variable names
mj-ramos 90ed258
torn writes: merge validate functions and return errors when fault ca…
mj-ramos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,4 +12,4 @@ blocks_per_page=1 | |
# no_pages=10 | ||
[filesystem] | ||
log_all_operations=false | ||
logfile="" | ||
logfile="" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggestions here before diving deep into a review:
If we want to add a
type="clear"
fault, then we must maintain the already known syntax, which istype=clear-cache
, which indicates that specifyingcrash=false
(assume default) has the same effect has sendinglazyfs::clear-cache
to the faults fifo.crash=true
, we must removelazyfs::crash
from the API and replace bylazyfs::clear-cache
with more options, namely thetiming
,op
,occurrence
, andcrash
(e.g.,lazyfs::clear-cache::timing=...::op=...::occurrence=...::crash
), wherecrash
may be omitted (optional parameter).clear-cache
without atiming
andop
, but he can sendlazyfs::clear-cache::crash
to the fifo to simulate "crash right now".Instead of the above, why can't we just add support for the existing
lazyfs::crash
fault under the config file? Do we need to specify a timing for the clear cache without crashing LazyFS?WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TL;DR: We going with option 1, but maintaining the
crash
fault option for now and will probably deprecate it soon. @mj-ramos Can you please change the fault syntax of theclear
fault type toclear-cache
?