[UX] Minor improvements of dstack metrics
#2667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Show run/job status * Better-format GPU metrics * Allow finished runs * Show GB (instead of MB)
jvstme
approved these changes
May 20, 2025
Collaborator
There was a problem hiding this comment.
Show GB (instead of MB)
I don't think gigabyte granularity is enough.
- It makes metrics useless for low-memory instances. Many clouds provide instances with only 1GB of RAM, some even provide 0.5GB RAM, including AWS. Such instances require precise memory consumption monitoring.
- It makes it more difficult to see metric changes with
dstack metrics -w. A metric can be growing or falling slowly but steady, which can be easily noticeable with megabyte, but not gigabyte granularity.
I suggest showing gigabytes with 2-3 digits after the decimal point, or reverting to megabyte granularity for both RAM and VRAM.
jvstme
approved these changes
May 21, 2025
Co-authored-by: jvstme <[email protected]>
Co-authored-by: jvstme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2316