Skip to content

Support new Azure CPU series #2668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support new Azure CPU series #2668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/packer/azure-image-cuda.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"azure_tenant_id": "{{env `AZURE_TENANT_ID`}}",
"azure_subscription_id": "{{env `AZURE_SUBSCRIPTION_ID`}}",
"azure_location": "westeurope",
"azure_vm_size": "Standard_DS1_v2",
"azure_vm_size": "Standard_D2s_v6",
"build_prefix": "",
"docker_version": "",
"cuda_drivers_version": "",
Expand Down
2 changes: 1 addition & 1 deletion scripts/packer/azure-image-grid.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"azure_tenant_id": "{{env `AZURE_TENANT_ID`}}",
"azure_subscription_id": "{{env `AZURE_SUBSCRIPTION_ID`}}",
"azure_location": "westeurope",
"azure_vm_size": "Standard_DS1_v2",
"azure_vm_size": "Standard_D2s_v6",
"build_prefix": "",
"docker_version": "",
"image_version": ""
Expand Down
2 changes: 1 addition & 1 deletion scripts/packer/azure-image.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"azure_tenant_id": "{{env `AZURE_TENANT_ID`}}",
"azure_subscription_id": "{{env `AZURE_SUBSCRIPTION_ID`}}",
"azure_location": "westeurope",
"azure_vm_size": "Standard_DS1_v2",
"azure_vm_size": "Standard_D2s_v6",
"build_prefix": "",
"docker_version": "",
"image_version": ""
Expand Down
5 changes: 3 additions & 2 deletions scripts/publish_azure_image.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ function get_image_definition {
}

# We create a separate image definition for each dstack version since
# gallery-image-version can't be in one-to-one correspondance with dstack versions
# gallery-image-version can't be in one-to-one correspondence with dstack versions
# (it has to follow semver, e.g. no rc)
function create_image_definition() {
echo Creating image definition...
Expand All @@ -33,7 +33,8 @@ function create_image_definition() {
--sku $image_definition \
--os-type Linux \
--os-state generalized \
--hyper-v-generation V2
--hyper-v-generation V2 \
--features DiskControllerTypes=SCSI,NVMe
}

function create_image_version() {
Expand Down
12 changes: 7 additions & 5 deletions src/dstack/_internal/core/backends/azure/compute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,11 +391,8 @@ def get_image_name(self) -> str:


_SUPPORTED_VM_SERIES_PATTERNS = [
# TODO: Support newer CPU series (Dsv6, Esv6).
# They are NVMe-only and require marking the VM image as NVMe.
r"D(\d+)s_v3", # Dsv3-series (general purpose)
r"E(\d+)i?s_v4", # Esv4-series (memory optimized)
r"E(\d+)-(\d+)s_v4", # Esv4-series (constrained vCPU)
r"D(\d+)s_v6", # Dsv6-series (general purpose)
r"E(\d+)i?s_v6", # Esv6-series (memory optimized)
r"F(\d+)s_v2", # Fsv2-series (compute optimized)
r"NC(\d+)s_v3", # NCv3-series [V100 16GB]
r"NC(\d+)as_T4_v3", # NCasT4_v3-series [T4]
Expand All @@ -404,6 +401,11 @@ def get_image_name(self) -> str:
r"NC(\d+)ads_A100_v4", # NC A100 v4-series [A100 80GB]
r"ND(\d+)asr_v4", # ND A100 v4-series [8xA100 40GB]
r"ND(\d+)amsr_A100_v4", # NDm A100 v4-series [8xA100 80GB]
# Deprecated series
# TODO: Remove after several releases
r"D(\d+)s_v3", # Dsv3-series (general purpose)
r"E(\d+)i?s_v4", # Esv4-series (memory optimized)
r"E(\d+)-(\d+)s_v4", # Esv4-series (constrained vCPU)
]
_SUPPORTED_VM_SERIES_PATTERN = (
"^Standard_(" + "|".join(f"({s})" for s in _SUPPORTED_VM_SERIES_PATTERNS) + ")$"
Expand Down
Loading