Bugfix 537 vert xaxis

[bikegeek]

Pull Request Testing

• Describe testing already performed for these changes:
  

  generated plots via command line for the following cases:

  • no xlim (xmin, xmax) range for x-axis (Plotly determines xmin, xmax labels/values on x-axis)

  • specified various (xmin, xmin) values via xlim setting in YAML and verified the x-axis labels are consistent with what was requested
    - integer and float values used
    - float values are rounded to nearest int
    - temporarily "dumped" x, and y values into a pandas dataframe and plotted these values in a jupyter notebook to verify that the plot and vertical plot using simple Plotly scatter plot produce appropriate plots (indicating that the x- and y- values used in the vertical plot are correct)

  • installed METplotpy bugfix_537_vert_axis fix to METplotpy on 'dakota' and 'mohawk'

    • reproduced the RRFS plots and verified correct behavior

The following data was used to generate the plots via command line:

vert_line_plot_data.txt

The following YAML config files were used:

No range specified, Plotly generates the x-axis labels
no_range_specified.yaml.txt

Decimal values for range:
decimals_range.yaml.txt

Integer values for range:
integer_range.yaml.txt

Plots generated from above config files:

No range specified plot:

Decimal range specified (-1.5, 3), step of 1.1 - rounding of floats to closest int:

Integer range specified (-2,2):

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

For Michelle H:
- verify plotting of vertical plots is correct via METviewer
- code updates on METviewer on both 'dakota' and 'mohawk'

For Julie P:
- verify that code changes look OK
- I fixed some typos and removed some redundant code

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]

• Do these changes include sufficient testing updates? [NA]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Do these changes introduce new SonarQube findings? [Yes]
  
  If yes, please describe:
  Expect the Quality Gate to fail due to Coverage value falling below threshold

• Please complete this pull request review by [Fill in date].
  

Pull Request Checklist

See the METplus Workflow for details.

• Add any new Python packages to the METplus Components Python Requirements table.
• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s) and Development issue
  Select: Milestone as the version that will include these changes
  Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases
• After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.