Skip to content

Remove deprecated Compiler.compile wrapper#16

Closed
nthbotast wants to merge 1 commit intodtsong:masterfrom
nthbotast:fix-remove-deprecated-compile-wrapper
Closed

Remove deprecated Compiler.compile wrapper#16
nthbotast wants to merge 1 commit intodtsong:masterfrom
nthbotast:fix-remove-deprecated-compile-wrapper

Conversation

@nthbotast
Copy link

Summary

Implements #7 by removing the deprecated Compiler.compile() wrapper in data_diff/databases/base.py.

What changed

  • Removed deprecated method:
    • Compiler.compile(self, elem, params=None)
  • Updated test callers to use the canonical path directly:
    • compiler.dialect.compile(compiler, expr)

This removes deprecated API surface and keeps callsites explicit.

Notes

I also updated the affected tests (tests/test_query.py, tests/test_sql.py) to reflect the new usage.

@dtsong
Copy link
Owner

dtsong commented Mar 2, 2026

Thanks for the contribution! However, this work was already completed in PR #17 (commit f070d2b), which removed the deprecated Compiler.compile() wrapper and updated all test callsites.

Since master already reflects these changes, I'm going to close this one out. If you're interested in contributing, we have several open issues that could use help — feel free to take a look!

@dtsong dtsong closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants