Remove deprecated Compiler.compile wrapper#16
Closed
nthbotast wants to merge 1 commit intodtsong:masterfrom
Closed
Remove deprecated Compiler.compile wrapper#16nthbotast wants to merge 1 commit intodtsong:masterfrom
nthbotast wants to merge 1 commit intodtsong:masterfrom
Conversation
Owner
|
Thanks for the contribution! However, this work was already completed in PR #17 (commit f070d2b), which removed the deprecated Since master already reflects these changes, I'm going to close this one out. If you're interested in contributing, we have several open issues that could use help — feel free to take a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #7 by removing the deprecated
Compiler.compile()wrapper indata_diff/databases/base.py.What changed
Compiler.compile(self, elem, params=None)compiler.dialect.compile(compiler, expr)This removes deprecated API surface and keeps callsites explicit.
Notes
I also updated the affected tests (
tests/test_query.py,tests/test_sql.py) to reflect the new usage.