Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14be6c28ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| token_key = classification + "_max_tokens" | ||
| if word_key in override: | ||
| return override[word_key], override.get(token_key, budgets.get(token_key)) | ||
| return override[word_key], override[token_key] |
There was a problem hiding this comment.
Keep fallback when override omits token limit
get_budget_limits now indexes override[token_key] directly whenever a per-file *_max_words override exists. Overrides are allowed to set only word limits (for example, the governance spec’s budgets.json sample shows specialist_max_words without specialist_max_tokens), so this now raises KeyError and causes pipeline/scripts/budget-report.py to fail on valid configuration instead of falling back to the default or derived token ceiling.
Useful? React with 👍 / 👎.
Governance Upgrade: v1.4.1
Automated upgrade from skill-governance v1.4.1.
Changes
Release Notes
See the full release notes.
Post-Merge Checklist
pre-commit run --all-filesafter merge.governance-versionreadsv1.4.1