Skip to content

chore(governance): upgrade to v1.4.1#13

Merged
dtsong merged 1 commit intomainfrom
governance/upgrade-v1.4.1
Mar 8, 2026
Merged

chore(governance): upgrade to v1.4.1#13
dtsong merged 1 commit intomainfrom
governance/upgrade-v1.4.1

Conversation

@dtsong
Copy link
Owner

@dtsong dtsong commented Feb 23, 2026

Governance Upgrade: v1.4.1

Automated upgrade from skill-governance v1.4.1.

Changes

 .governance-version                        |  2 +-
 pipeline/config/model-routing.yaml         | 29 ++++++++++-------------------
 pipeline/config/security-suppressions.json |  3 ++-
 pipeline/hooks/check_references.py         |  6 ++++++
 pipeline/scripts/analyze-patterns.py       |  0
 pipeline/scripts/budget-report.py          |  2 +-
 pipeline/scripts/check-regressions.py      |  0
 pipeline/scripts/context-load-analysis.py  |  0
 pipeline/specs/SKILL-MODEL-ROUTING-SPEC.md | 20 +++++++++++++++-----
 9 files changed, 35 insertions(+), 27 deletions(-)

Release Notes

See the full release notes.

Post-Merge Checklist

  • Review diff for suite-specific overrides that may need attention
  • Run pre-commit run --all-files after merge
  • Verify .governance-version reads v1.4.1

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 14be6c28ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

token_key = classification + "_max_tokens"
if word_key in override:
return override[word_key], override.get(token_key, budgets.get(token_key))
return override[word_key], override[token_key]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep fallback when override omits token limit

get_budget_limits now indexes override[token_key] directly whenever a per-file *_max_words override exists. Overrides are allowed to set only word limits (for example, the governance spec’s budgets.json sample shows specialist_max_words without specialist_max_tokens), so this now raises KeyError and causes pipeline/scripts/budget-report.py to fail on valid configuration instead of falling back to the default or derived token ceiling.

Useful? React with 👍 / 👎.

@dtsong dtsong merged commit 7f302ac into main Mar 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant