feat: standardize skill descriptions for better matching#13
feat: standardize skill descriptions for better matching#13
Conversation
…cil] prefix Update all 16 standalone skill descriptions to follow the format: [ACTION_TRIGGER] [DOMAIN_SCOPE]. Triggers on: [phrases]. Not for: [exclusion]. Add [Council] prefix to all 46 council department skill descriptions with "Used during council/academy deliberation only." suffix for clear scoping. This improves skill matching accuracy by giving Claude better signals for intent classification and domain boundary detection. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fdb403320e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| --- | ||
| name: web-design-guidelines | ||
| description: Review UI code for Web Interface Guidelines compliance. Use when asked to "review my UI", "check accessibility", "audit design", "review UX", or "check my site against best practices". | ||
| description: "Review UI code for Web Interface Guidelines compliance and accessibility. Triggers on: review my UI, check accessibility, audit design, review UX. Not for: visual design creation (use frontend-design) or React-specific optimization (use vercel-react-best-practices)." |
There was a problem hiding this comment.
This description now tells users to route visual design tasks to frontend-design, but there is no skill with that identifier in this repository (the only frontend-design occurrence is this line). In practice, requests that hit this exclusion path cannot be handed to the intended skill, which undermines the matching/routing improvement this commit is trying to achieve.
Useful? React with 👍 / 👎.
|
|
||
| **Bad tests** are coupled to implementation. They mock internal collaborators, test private methods, or verify through external means (like querying a database directly instead of using the interface). The warning sign: your test breaks when you refactor, but behavior hasn't changed. If you rename an internal function and tests fail, those tests were testing implementation, not behavior. | ||
|
|
||
| See [references/tests.md](references/tests.md) for examples and [references/mocking.md](references/mocking.md) for mocking guidelines. |
There was a problem hiding this comment.
The newly added TDD skill links to references/tests.md and references/mocking.md (and later to other references/* docs), but this commit does not add a skills/tdd/references/ tree. Following the documented skill workflow, these links are expected to be loadable; leaving them unresolved makes core guidance unavailable and the skill effectively incomplete.
Useful? React with 👍 / 👎.
1 participant
Summary
[ACTION_TRIGGER] [DOMAIN_SCOPE]. Triggers on: [phrases]. Not for: [exclusion].[Council]prefix and "Used during council/academy deliberation only" suffix to all 46 council department skill descriptionsTest plan
grep -c "Not for:" skills/*/SKILL.md[Council]prefix:grep -c "\[Council\]" skills/council/*/*/SKILL.mddescriptionfield was modified🤖 Generated with Claude Code