Repository navigation
Add Mark all as canceled on risk review - #4793
Closed
steven-tey wants to merge 2 commits into
Closed
steven-tey wants to merge 2 commits into
steven-tey wants to merge 2 commits into
Conversation
This reverts commit 751c363. Co-authored-by: Steven Tey <steven@dub.co>
Let reviewers mark held commissions as canceled from the risk sheet, and show the partner's network status and program enrollment status while they review the event. Co-authored-by: Steven Tey <steven@dub.co>
Contributor
WalkthroughWarning Review details and warnings were omitted to fit the comment limit. |
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+13
to
+33
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@v3 | ||
| with: | ||
| version: 8 | ||
| - name: Install dependencies & build | ||
| run: pnpm --filter @dub/embed-core build | ||
|
|
||
| # - name: Deploy to Cloudflare Pages (https://www.dubcdn.com/embed/script.js) | ||
| # uses: cloudflare/wrangler-action@v3 | ||
| # with: | ||
| # apiToken: ${{ secrets.CLOUDFLARE_PAGES_API_KEY }} | ||
| # accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }} | ||
| # command: pages deploy dist/embed/script.js --project-name=dub-cdn --commit-dirty=true | ||
| # workingDirectory: packages/embeds/core | ||
| # packageManager: pnpm |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
| const stripeCustomerId = text.match(/cus_[a-zA-Z0-9]+/)?.[0]; | ||
| if ( | ||
| stripeCustomerId && | ||
| (text.startsWith("cus_") || text.includes("stripe.com")) |
| const stripeCustomerId = query.match(STRIPE_CUSTOMER_ID_REGEX)?.[0]; | ||
| if ( | ||
| stripeCustomerId && | ||
| (query.startsWith("cus_") || query.includes("stripe.com")) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
canceled, so held commissions can be canceled without changing the dropdown. The bulk commissions update already accepts that status.main, so the button had nowhere to live.Testing
tsc --noEmitinapps/webpasses.