Repository navigation
Point Errors For Unreadable Glue Tables To glue_get_table_response() - #82
Merged
Merged
Conversation
Richard-Durkee
force-pushed
the
glue-describe-otf
branch
3 times, most recently
from
October 9, 2026 13:01
d125b80 to
70db101
Compare
Richard-Durkee
marked this pull request as ready for review
October 9, 2026 16:12
Richard-Durkee
force-pushed
the
glue-describe-otf
branch
2 times, most recently
from
October 9, 2026 22:33
8ccae7e to
73b07d6
Compare
Tmonster
reviewed
Oct 11, 2026
Tmonster
left a comment
Tmonster
left a comment
Member
There was a problem hiding this comment.
I think we can alter the error message thrown in in GlueTableInfo::GetFileFormat Then we also won't have to introduce all the extra function data/information.
Either GlueTableInfo::GetFileFormat can return HiveFileFormat::Unsupported and the calling function can use that to throw. GetFileFormat is used to bind read and write operations though, so I think it's safe to throw there and mention glue_get_table_response
| return GetHiveScanFunction(context, bind_data, latest_info); | ||
| } | ||
| default: | ||
| throw NotImplementedException("Scan from table with type %s", latest_info.GetFormatName()); |
Member
There was a problem hiding this comment.
We should not be throwing here is the Hive table is backed by a format DuckDB cannot read yet. Here we throw if the otf is an oft that duckdb-aws-glue does not support yet (like Delta)
Richard-Durkee
force-pushed
the
glue-describe-otf
branch
from
October 11, 2026 16:50
73b07d6 to
6fc700f
Compare
Richard-Durkee
changed the title
Member
|
Csv regression tests are flaky |
Member
|
Thanks! |
Tmonster
pushed a commit
to Tmonster/duckdb-aws-glue
that referenced
this pull request
Oct 12, 2026
glue_table.cpp: the per-query Glue table entry of this branch with the error message of duckdb#82 for tables that can not be read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a query binds a Glue table the extension can't read, the error now says how to inspect the table instead:
GlueTableInfo::GetFileFormatas before, which covers reads and writes. The message now ends with "use glue_get_table_response() to inspect the table definition".GlueTable::GetScanFunctionwithGlue table 'db.t' has table format DELTA, which can not be read yet; use glue_get_table_response() to inspect its definition, instead ofScan from table with type DELTA.DESCRIBEbinds the table, so it fails with the same messages. Describing open table formats is left to format-specific support.