Skip to content

fix: resolve compile error in statements.cpp #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

joakimlinde
Copy link
Contributor

@joakimlinde joakimlinde commented May 9, 2025

The assert in file statement.cpp:178 refers to a variable nrows that does not exist. This causes a compile error. I opted to change the variable name rows to nrows in order to make it consistent with ncols. Please feel free to change it to the other way.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.31%. Comparing base (5c88c6f) to head (c403987).
Report is 1539 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1149       +/-   ##
===========================================
- Coverage   63.61%   52.31%   -11.30%     
===========================================
  Files         123      146       +23     
  Lines        5266     9941     +4675     
===========================================
+ Hits         3350     5201     +1851     
- Misses       1916     4740     +2824     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joakimlinde joakimlinde deleted the fix/compile-error-in-statement branch May 13, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants