Set orientation to landscape when entering full screen #3265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the late response here. We are currently checking staled PRs, and we are closing this one as per our contributions guidelines, we only accept contributions for accepted issues and labeled as Help Wanted. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL:
#3250
Description
Hi! I'm interested in fixing the issue.
This pull request code is adapted from how Lightning Browser works when YouTube video enters full screen mode. Here's I attach the source code of it. https://github.com/anthonycr/Lightning-Browser/blob/browser2/app/src/main/java/acr/browser/lightning/browser/BrowserActivity.kt please look at method
showCustomView()andhideCustomView().So, this code will make the app turn into landscape mode whenever it enters full screen mode. I haven't tested it on Twitter or TikTok that could have vertical video format.
Steps to test this PR
Same as Issue URL
Feature 1
UI changes
Before
After
