Preparations for UI Experiments

[malmstein]

Task/Issue URL: https://app.asana.com/0/488551667048375/1209289914504437

Description

Steps to test this PR

Enable Experimental UI

• Install app in Internal flavour
• Open Appearance screen
• Verify “Enable Experimental UI” is visible
• Toggle it on and restart the app
• Verify has a pink tint
• Open Appearance screen and toggle the experimental feature offf
• Verify app is back to the original colors after restart

Enable Experimental UI

• Install app in release flavour
• Open Appearance screen
• Verify “Enable Experimental UI” is not visible

[malmstein]

• Preparations for UI Experiments #5627 👈 (View in Graphite)
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

[LukasPaczos]

We also need to handle the DARK_EXPERIMENT value in

Android/common/common-ui/src/main/java/com/duckduckgo/common/ui/DuckDuckGoActivity.kt

Lines 90 to 102 in 3acaa58

	fun isDarkThemeEnabled(): Boolean {
	return when (themingDataStore.theme) {
	DuckDuckGoTheme.SYSTEM_DEFAULT -> {
	val uiManager = getSystemService(Context.UI_MODE_SERVICE) as UiModeManager
	when (uiManager.nightMode) {
	UiModeManager.MODE_NIGHT_YES -> true
	else -> false
	}
	}
	DARK -> true
	else -> false
	}
	}

[LukasPaczos]

getSystemDefaultTheme also needs to be updated to return either the regular or experiment themes.

[malmstein]

During internal testing we only want to change Light / Dark. Users on system theming won’t be able to see the experimental colors.

[LukasPaczos]

This sounds somewhat counter-intuitive for me. The new flag governs whether the experimental light/dark theme is applied, we shouldn't require from internal users any additional implicit steps. The default setting is the "system theme", and in the end it applies one of the light or dark themes, so in my opinion it should respect the experiment flag as well.

[malmstein]

"we shouldn't require from internal users any additional implicit steps”. this is still to be decided, for now we will keep it simple and iterate in the project.

[LukasPaczos]

One more small change needed:

Android/app/src/main/java/com/duckduckgo/app/appearance/AppearanceActivity.kt

Lines 170 to 180 in 3acaa58

	val currentTheme = theme.getOptionIndex()
	RadioListAlertDialogBuilder(this)
	.setTitle(R.string.settingsTheme)
	.setOptions(
	listOf(
	R.string.settingsSystemTheme,
	R.string.settingsLightTheme,
	R.string.settingsDarkTheme,
	),
	currentTheme,
	)

currentTheme should be mapped back to light/dark when experimental is provided. Otherwise, nothing is pre-selected when the experiment is enabled and radio menu opens.

[LukasPaczos]

Thanks for addressing the comments, let's merge and continue but please cut follow up tasks for:

• Preparations for UI Experiments #5627 (comment)
• Preparations for UI Experiments #5627 (review)

if not addressed here.