Target Android 15: Add ELF alignment verification CI check #5634
+132
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikescamell
force-pushed
the
feature/mike/android-15-16kb
branch
2 times, most recently
from
d80c3b0 to
3eae73b
Compare
mikescamell
changed the title
malmstein
reviewed
Feb 13, 2025
| run: chmod +x scripts/check_elf_alignment.sh | ||
|
|
||
| - name: Check native libraries alignment | ||
| run: ./scripts/check_elf_alignment.sh ${{ steps.find-apk.outputs.apk_path }} |
There was a problem hiding this comment.
how about capturing the output and post a summary in the workflow? if you open a failed action now it shows as if Android CI tests fails, and opening the details shows that there are no tests.
provided by Google with a couple of tweaks with exit status so we can fail the workflow
we're adding the check in the android_tests as we already need an apk to run the tests, so we're not having to build multiple apks and slowing everything down we considered after PR merge but that meant the person would only find out after that something they are using is not aligned
mikescamell
force-pushed
the
feature/mike/android-15
branch
from
563db61 to
d836cb4
Compare
mikescamell
force-pushed
the
feature/mike/android-15-16kb
branch
from
3eae73b to
629b8ff
Compare
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1209378846484863
Description
Added ELF alignment verification to the CI pipeline to ensure native libraries are properly aligned at 16KB or 64KB boundaries. This includes a new shell script that checks alignment in APK files and reports any misaligned libraries.
A passing build using playDebug: https://github.com/duckduckgo/Android/actions/runs/13291887849/job/37114510525?pr=5634
A failing build using internalDebug (because of Flipper which we know about)
https://github.com/duckduckgo/Android/actions/runs/13292470506/job/37116369658?pr=5634
Steps to test this PR
ELF Alignment Verification
./gradlew androidTestsBuild./scripts/check_elf_alignment.sh path/to/your/app.apkUI changes
No UI changes in this PR