Skip to content

Conversation

0nko
Copy link
Member

@0nko 0nko commented Mar 31, 2025

Task/Issue URL: https://app.asana.com/0/72649045549333/1209555017459056/f

Description

This PR adds the new string translations.

Smartling job: https://dashboard.smartling.com/app/projects/b01b53ede/account-jobs/b01b53ede:ohk4swnhhuv0

Steps to test this PR

  • Change the device language
  • Start the app
  • Go to the tab switcher screen
  • Smoke test the tab selection and verify the correct language is displayed

Copy link
Member Author

0nko commented Mar 31, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@0nko 0nko changed the title Move the new strings to strings.xml for translation Multi-selection: Translations Mar 31, 2025
@0nko 0nko marked this pull request as ready for review March 31, 2025 17:30
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-translation branch from 0e54338 to 0b534bd Compare April 1, 2025 17:27
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-tests branch from 6d3797f to 063ebcd Compare April 1, 2025 17:27
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-translation branch from 13d87b2 to 725c456 Compare April 2, 2025 10:09
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-tests branch from 063ebcd to 2eb7f29 Compare April 2, 2025 10:09
@0nko 0nko changed the base branch from feature/ondrej/tab-multi-selection-tests to graphite-base/5840 April 2, 2025 10:18
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-translation branch from 725c456 to 12ac334 Compare April 2, 2025 11:05
@0nko 0nko changed the base branch from graphite-base/5840 to feature/ondrej/tab-multi-selection April 2, 2025 11:05
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection-translation branch from bda4f31 to b744a85 Compare April 2, 2025 16:19
@0nko 0nko force-pushed the feature/ondrej/tab-multi-selection branch from ae964cb to 08c2d69 Compare April 2, 2025 16:19
@0nko 0nko requested a review from mikescamell April 2, 2025 18:05
@mikescamell mikescamell self-assigned this Apr 3, 2025
@mikescamell
Copy link
Contributor

LGTM

@0nko 0nko merged commit 8e56d79 into feature/ondrej/tab-multi-selection Apr 3, 2025
4 of 6 checks passed
@0nko 0nko deleted the feature/ondrej/tab-multi-selection-translation branch April 3, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants