Skip to content

Conversation

noisysocks
Copy link
Contributor

@noisysocks noisysocks commented Jul 22, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1209121419454298/task/1210842882517721?focus=true

Description

Adjust the Omnibar widget’s focus ring styling to match the spec and hide it when user starts typing in the Duck.ai form.

Testing Steps

Browse to https://deploy-preview-1838--content-scope-scripts.netlify.app/build/pages/new-tab/?omnibar=true and type into the Search or Duck.ai fields. Search for “pizza” to see suggestions.

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@noisysocks noisysocks added the bug Something isn't working label Jul 22, 2025
@noisysocks noisysocks requested a review from a team as a code owner July 22, 2025 01:39
Copy link

netlify bot commented Jul 22, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 2a5fd75
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/6880ab6f5774280008ad9f87
😎 Deploy Preview https://deploy-preview-1838--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@noisysocks noisysocks changed the title Remove focus ring when typing NTP Omnibar: Remove focus ring when typing Jul 22, 2025
Copy link

github-actions bot commented Jul 22, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jul 22, 2025

[Beta] Generated file diff

Time updated: Wed, 23 Jul 2025 09:30:14 GMT

Integration
    - integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js

File has changed

Apple
    - dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js

File has changed

cursor[bot]

This comment was marked as outdated.

shakyShane
shakyShane previously approved these changes Jul 22, 2025
@noisysocks noisysocks changed the title NTP Omnibar: Remove focus ring when typing NTP Omnibar: Adjust focus ring styling and remove it when typing Jul 23, 2025
cursor[bot]

This comment was marked as outdated.

@noisysocks noisysocks requested a review from shakyShane July 23, 2025 08:59
@noisysocks noisysocks added this pull request to the merge queue Jul 23, 2025
@jonathanKingston jonathanKingston removed this pull request from the merge queue due to the queue being cleared Jul 23, 2025
@noisysocks noisysocks merged commit 659a231 into main Jul 23, 2025
16 checks passed
@noisysocks noisysocks deleted the randerson/omnibar-remove-focus-when-typing branch July 23, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants