Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kun/team section #188

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Kun/team section #188

wants to merge 14 commits into from

Conversation

SatapasT
Copy link
Contributor

No description provided.

@Lordfirespeed
Copy link
Member

okay so a few things

  • the background of the section should not interrupt the background of the site as a whole. The background colour should be localised to a 'card' shape (the slides in the carousel)
  • you'll need to do something to make sure each slide is the same size
  • font of the team name should be the heading font, I think
  • mobile responsiveness

@Lordfirespeed
Copy link
Member

Lordfirespeed commented Oct 27, 2024

Looking better :)

The cards have no background at all, now. Here's what it should kind of look like:
image
Use a more appropriate colour than I have, and make sure corners are rounded.

Team names still aren't in the heading font. font-heading is not the way you do that.
Team names' font size should not exceed the section title font size.

Please can you make the 'team members' div height consistent across the tiles? That should ensure image sizes are consistent between tiles

Something is wrong with positioning; when I scroll down 2 slides quickly in mobile layout, the bottom image from previous slide is underneath the slide title

The 'head of team' picture is too large in both layouts

Cards' width should match the width of images in the gallery

@Lordfirespeed
Copy link
Member

Lordfirespeed commented Nov 4, 2024

okay, you have taken some liberties with 'more appropriate color' 😂

Looking better!

  • Slides have backgrounds now (great)
  • Images are consistently sized
  • team titles are in heading font 🎊

Amendments:

  • Slide title text is not aligned with body text (it can stay right-aligned, just please ensure they are right-aligned to the same place)
  • please flat colour background, something dark. Maybe similar to the colour of 'space' around the moon.
  • please remove borders around images
  • please add hacker experience team
  • please ask Design/marketing for descriptions of each team's role, explaining what the descriptions will be used for
  • fix typo: Sponsiership -> Sponsorship
  • consistency: either all slides should be titled ... Team or none of them should
  • please fix images: Jacob is not the head of 3 teams 😭
    • If you need a list of who is on what team, let me know
  • Please can we add a little piece of text by each image saying people's first names
    • for heads of teams, underneath
    • for everyone else, above
    • you should use <Label htmlFor="blah">...</Label> and set id="blah" on the corresponding image - make sure the IDs are unique. I would do something like [teamname]-team-member-[firstname]-[lastname] e.g. finance-team-member-quinn-dines

@Lordfirespeed
Copy link
Member

This will resolve #197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants